On the other hand, the engine does provide representation-specific implementations of other user-facing, mostly-representation-agnostic tasks […]. If we can find a mostly-representation-agnosti…
Good to know. For now, I think it's worth clearly distinguishing the interior "builder" variable and the exterior "storage" variable, because they have some differences in usage: for example, the…
C) This very much has the look of engine code that has leaked into the assembly: nitty gritty dealing with the internal coordinates of an element.
Yes, I think this code is on the border…
B) Why do you have to do so much work updating the guess (I think that's what's going on) when you start regulating curvature, but it seems like you don't do much of anything when you start…
A) Seems like there is some duplication at least of structure/behavior here with the insert_new_product_regulator; is there anything that can be profitable factored out (some common insert_regula…
It also seems to me that Elements are ProblemPosers as well, but it's fine if that's not reflected in the software structure in this PR -- but you may want to contemplate that for #27.
Yes,…
I've fixed the example switcher regression and removed the work-in-progress flag! (The example switcher is now equally buggy on the main branch and on the branch to be merged. I'm not sure whether…
I've marked this PR as a work in progress because the example switcher is broken as of commit 81e423f. You're welcome to start reviewing while I debug the example switcher, because I expect the…
During review of #75, we decided to bundle all three checks together under cargo test, both in continuous integration and during local development. We can get granular information about failures…
I am presuming this scheme has no WASM-bundle footprint when compiled for deployment.
That's right. If I've set things up right, tests and examples are conditionally compiled, so they won't…
No, I have now updated the "branch protection" settings for the repository so that if /test is failing, merge is not allowed.
Awesome. I've confirmed that I'm blocked from merging too.
Oops, I can still merge this PR even in a failing state. I will try to adjust the settings.
While you look at the repository settings (or review efb2d39 and 440b1df), I'll check whether this…