Vectornaut
  • Joined on 2019-09-28
Vectornaut pushed to main at Vectornaut/dyna3 2025-06-04 23:10:40 +00:00
e447e7ea96 Dispatch normalization routines correctly (#87)
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-04 22:48:49 +00:00
Dispatch normalization routines correctly

don't forget to file that issue

Whoops, thanks for the reminder! This is now issue #90.

Vectornaut opened issue StudioInfinity/dyna3#90 2025-06-04 22:47:22 +00:00
Make the data types of element representations opaque to the assembly module
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-03 00:27:15 +00:00
Dispatch normalization routines correctly

During our meeting, we decided that cleaning up the forwarded project_to_normalized implementations will best be done in a dedicated pull request that encapsulates element representation data…

Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-02 23:24:36 +00:00
Dispatch normalization routines correctly

My first attempt to avoid forwarding the project_to_normalized implementations was:

  • Make project_to_normalized a method of a new engine::EngineElement trait.
  • Make `engine::EngineEleme…
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-02 22:04:28 +00:00
Dispatch normalization routines correctly

I am happy with the names but it seems cumbersome that there are methods project_XXX_to_normalized and then two boilerplate implementations of project_to_normalized that just forward to the…

Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-02 21:56:50 +00:00
Dispatch normalization routines correctly

The branch is out-of-date. I would just click "update branch by rebase" but I am not sure if you want me rebasing your branches, so please bring it up-to-date as you see fit (and let me know if…

Vectornaut pushed to dispatch-normalization at Vectornaut/dyna3 2025-06-02 21:49:52 +00:00
f332f755e0 Improve the naming of the normalization methods
e19792d961 Explain the new check-cfg lint
0cfdd59e23 Test curvature drift during position nudging
f4e5c34fde Add a trait method to normalize representations
a671a8273a Introduce ghost mode for elements (#85)
Compare 5 commits »
Vectornaut pushed to main at Vectornaut/dyna3 2025-06-02 20:45:35 +00:00
a671a8273a Introduce ghost mode for elements (#85)
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-01 23:11:04 +00:00
Dispatch normalization routines correctly

I've looked at the renaming commit again and I still think it's fine, so let me know what you think!

Vectornaut commented on pull request StudioInfinity/dyna3#85 2025-06-01 22:59:04 +00:00
Introduce ghost mode for elements

I guess this PR is working as is, but it just seems like a roundabout way to deal with colors... it's a bit hard for me to imagine that the ultimate version of the software will use this…

Vectornaut opened issue StudioInfinity/dyna3#88 2025-06-01 22:54:13 +00:00
Add direct opacity parameters for elements
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-06-01 17:52:22 +00:00
Dispatch normalization routines correctly

I just pushed a commit with better names (54b34e0582). My look-over before pushing was a bit cursory; I'll look at it harder later today.

Vectornaut pushed to dispatch-normalization at Vectornaut/dyna3 2025-06-01 17:50:13 +00:00
54b34e0582 Improve the naming of the normalization methods
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-05-30 21:19:52 +00:00
Dispatch normalization routines correctly

How about something like proj_to_normalized, to communicate that we're projecting the given representation vector to the normalized configuration variety for the given element type?

So I…

Vectornaut commented on pull request StudioInfinity/dyna3#85 2025-05-30 01:04:54 +00:00
Introduce ghost mode for elements

Any reason you didn't just make colors have an alpha channel everywhere […]?

I was thinking that when we add a user-facing opacity setting, we'll also need to figure out how it interacts…

Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-05-30 00:53:57 +00:00
Dispatch normalization routines correctly

Done in commit 8732cb7!

Vectornaut pushed to dispatch-normalization at Vectornaut/dyna3 2025-05-30 00:53:15 +00:00
8732cb77c2 Explain the new check-cfg lint
Vectornaut commented on pull request StudioInfinity/dyna3#87 2025-05-30 00:46:36 +00:00
Dispatch normalization routines correctly

In my mind, an element is represented by a line through the origin in \mathbb{R}^{4,1}, so choosing a favored representative is equivalent to choosing a particular scaling. That's why I used the…

Vectornaut created pull request StudioInfinity/dyna3#87 2025-05-21 01:23:31 +00:00
Dispatch normalization routines correctly