This seems acceptable to me. It leaves the code in an inconsistently formatted state, and one that neither of us seems entirely happy with, but I think we'll need Husht to resolve some of the…
Our current convention is to put spaces after the commas between arguments.
It's just an abbreviation.
Oh, I see: you're now trying to find a name short enough to jam that expression into one line. Personally, I think the extra clarity is worth an extra line.…
I'll admit I am looking for a two-line solution here.
All of the reasonable two-line solutions I can think of seem equally hard to read to me, and equally in violation of the [Rust](https://do…
To me, turning a variable called value into a variable called spec_val seems more understandable than turning a variable called value into a variable called val. In the latter case, the…
I think the main obstacle here is my preferred way to format nesting in language with C-like syntax, [described above](StudioInfinity/dyna3#128 (comment)…
I am also a strong advocate for laying out code as closely as one would lay out other forms of text, equations in articles, etc.
This is helpful guideline, and we should keep it in mind when…
The main thing I find confusing about the current formatting is that the -> DVector<f64> is part of the function declaration, but no indentation is used to show this. If you find bracket on next…
Well that's how it was, but i was trying to accommodate the preference for breaking at a method call instead of within the arguments.
Oh, I see. Like I said [above](https://code.studioinfinity…
I find (2) above most readable when more than one dot item is chained, so I guess I'd be fine with switching back to Python-style hanging indent for single method calls. I realize that this is…
My current attempt was motivated by your apparent preference to split before a
., rather than just after a(. Is that not the case?
My preferences are:
- In languages with C-like…
How about depth_if_hit? To me, this communicates that the value will be Some(depth) if we hit elt and None if we missed.
Tried to go through and reformat accordingly.
Thanks! I've flagged a few missed occurrences in the next review.