Simplify the realization triggering system #105

Merged
glen merged 6 commits from Vectornaut/dyna3:reactive-realization-cleanup into main 2025-07-31 22:21:34 +00:00

6 commits

Author SHA1 Message Date
Aaron Fenyes
779c0260bb Explain why the empty-assembly case is special
All checks were successful
/ test (pull_request) Successful in 3m35s
2025-07-29 13:48:40 -07:00
Aaron Fenyes
eafb133f8d Drop eigenvalue logging from symmetric_kernel
All checks were successful
/ test (pull_request) Successful in 3m30s
2025-07-29 00:45:33 -07:00
Aaron Fenyes
ca57fbce86 Correct the indentation of an empty line
All checks were successful
/ test (pull_request) Successful in 3m36s
2025-07-28 10:45:56 -07:00
Aaron Fenyes
2bae8d3df9 Prevent unused imports for engine debug output
All checks were successful
/ test (pull_request) Successful in 3m38s
In the process, switch from the `web-sys` crate's `console::log_1`
function to Sycamore's more flexible `console_log` macro. The latter
works both inside and outside the browser, so we can use it without
checking whether we're compiling to WebAssembly.
2025-07-24 16:32:18 -07:00
Aaron Fenyes
03d6cf0687 Flag our workaround for a Sycamore batching bug
Add a reminder to remove the workaround once the bug is fixed.
2025-07-24 16:09:26 -07:00
Aaron Fenyes
c73008d702 Trigger realization more directly
Some checks failed
/ test (pull_request) Failing after 1m35s
Simplify the system that reactively triggers realizations, at the cost
of removing the preconditioning step described in issue #101 and doing
unnecessary realizations after certain kinds of updates.

The new system should trigger a realization after any update that could
affect the assembly's deformation space. For simplicity, any update to
the regulator list triggers an update, even if it doesn't affect the set
of constraints. In particular, adding a regulator triggers an
unnecessary realization.
2025-07-24 15:21:19 -07:00