chore: Remove trailing whitespace #129
No reviewers
Labels
No labels
bug
design
duplicate
engine
enhancement
maintenance
prospective
question
regression
stub
todo
ui
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: StudioInfinity/dyna3#129
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "glen/dyna3:noTrailingWhitespace"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The rebase left lots of spurious commits (do you know how to avoid that?) but it is irrelevant in that the diffs remain just that all trailing whitespace is removed and carriage returns added at the end of files. So when this is squash-merged, the commit history will be clean. Thanks for reviewing.
I've done the following checks:
Do you know whether we can also apply this style to the YAML files that specify our Forgejo actions? If you're not sure, I can try it out later by running continuous integration locally.
@Vectornaut wrote in #129 (comment):
I believe so. Do you want me to make that change as part of this PR? I am equally willing to just wait until we have some reason to touch the YAML files. Up to you, let me know.
Yes: I'd rather do the reformatting in this dedicated PR than add noise to an unrelated PR. I just confirmed that the reformatted YAML files work when I run CI locally, so this should be an easy addition.
OK, I have now removed trailing whitespace throughout the repository, except within the engine-proto Julia code, with which I have not really concerned myself. (If you would like me to do it there as well, just let me know, but I have no opinion either way.)
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.