glen/math5
2
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Remove string-based type injection via ship() #8

Merged
glen merged 1 commits from fix/no_ship_inject into main 2024-10-21 21:46:53 +00:00
Conversation 1 Commits 1 Files Changed 1 +3 -25
glen commented 2024-10-21 17:16:02 +00:00
Owner
Copy Link

@josdejong OK so I merged the parsed reflection via property assignments to feat/reflect-types, and then merged that into main (but didn't delete the branch in case there was something you still might want with it). Now I've prepared this PR that removes the string-based type reflection in ship(), but will wait to merge it until I hear from you that this seems good to go with. Next after this we can rename ship() to done() as desired. So either merge this PR or give me the green light to go ahead and merge, thanks.

Resolves #6.

@josdejong OK so I merged the parsed reflection via property assignments to feat/reflect-types, and then merged that into main (but didn't delete the branch in case there was something you still might want with it). Now I've prepared this PR that removes the string-based type reflection in ship(), but will wait to merge it until I hear from you that this seems good to go with. Next after this we can rename ship() to done() as desired. So either merge this PR or give me the green light to go ahead and merge, thanks. Resolves #6.
glen added 1 commit 2024-10-21 17:16:02 +00:00
josdejong commented 2024-10-21 18:20:07 +00:00
Collaborator
Copy Link

Fine with me, you can press the merge button 👍

Fine with me, you can press the merge button 👍
glen force-pushed fix/no_ship_inject from 20aa17df25 to f37379ff8f 2024-10-21 21:45:27 +00:00 Compare
glen merged commit 75a950e830 into main 2024-10-21 21:46:53 +00:00
glen deleted branch fix/no_ship_inject 2024-10-21 21:46:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: glen/math5#8
No description provided.
Delete Branch "fix/no_ship_inject"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?