glen/archematics
1
0
Fork 0
Code Issues 17 Pull Requests Packages Projects 1 Releases 2 Wiki Activity

feat: Get all of Rostamian's old pages working #44

Merged
glen merged 4 commits from rostamian_old into main 2023-10-18 01:07:58 +00:00
Conversation 0 Commits 4 Files Changed 5 +318 -110
glen commented 2023-10-18 01:07:43 +00:00
Owner
Copy Link

Implements the pivot parameter to the Geometry applet and numerous new construction methods.
Resolves #36.

Implements the pivot parameter to the Geometry applet and numerous new construction methods. Resolves #36.
glen added 4 commits 2023-10-18 01:07:43 +00:00 
These include circleSlider, line cutoff, and bichord. Also
  makes the order of points in the chord command more true to
  Joyce. Represents more progress on #36. Next up is dealing with
  the pivot parameter.
Dealing with general click and drag on the applet and differentiating
  between a background drag and dragging an element seemed like too big
  a task, so this PR simply provides a slider to rotate the diagram when
  the pivot is defined.

  Implementing this required storing much more construction data, and
  also dealing head-on with GeoGebra's shall we say "strange" choice where
  the value of an expression depends on what name it is assigned to...
  The resolution of this last bit was to use different GeoGebra names for
  Geometry Applet points that start with something other than an uppercase
  Roman letter.
This commit is just the last piece in the puzzle, implementing the
   perpendicular method for lines.
   Resolves #36.
glen merged commit 277d9b0a8c into main 2023-10-18 01:07:58 +00:00
glen deleted branch rostamian_old 2023-10-18 01:07:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Prototype

A task that does not directly add a feature or fix a bug but explores the route thereto

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
refactor

Internal change needed for future work, without immediate behavioral change

  
waiting

Does not appear any further work needed on our part at the moment; awaiting upstream events.

  
wontfix

This won't be fixed

No Label
Prototype
bug
duplicate
enhancement
help wanted
invalid
question
refactor
waiting
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: glen/archematics#44
No description provided.
Delete Branch "rostamian_old"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?