Here are updates on the prospective issues mentioned in the pull request description.
The new coordinate regulators create redundant display information with the raw representation…
I've edited this a bit, saving the original in case you want to compare and revert any of the changes.
The code and the resulting interface both look like what I expect, so I'd say this is resolved.
I agree that the comment in issue #90 is enough to remind us about this.
What sort of a redesign would you have in mind? How would you add this extra frozen coordinate? Would you want the…
assembly module
Instead, perhaps, the engine should be checking if all but one of the coordinates of an entity are frozen, and if so, freeze the third.
I'll expand on this a little, since we talked about it…
I'd prefer to just add a /* TO DO */ flag, because I think the best way to fix the issue would involve a broader discussion about the organization of the engine and assembly submodules, which is…
@glen wrote in StudioInfinity/dyna3#118 (comment):
OK, I think I've responded to everything so far, but of course a few of the items are far from…
The associated constant Axis::N_AXIS, which is defined by hand here, has the same value as the associated constant Axis::CARDINALITY, which is defined automatically when we derive the Sequence trait. I'd recommend removing N_AXIS and using CARDINALITY in its place. I'm confident that CARDINALITY is currently 3, because I get a compilation error if I replace it with a value different from 3 in the definition of Axis::NAME.
In the outline items for previously implemented regulators, we use the regulator-label div to say which other element, if any, is subject to the regulator, and we use the regulator-type label to say what's being regulated. To bring the outline item for the point coordinate regulator in line with this convention, I'd rewrite it like this.
I've been flagging desired edits like this with /* TO DO */ // This 3... rather than //FIXME: This 3.... I'd like to stick to that format, because I think keeping flags consistent makes it easier to search for flagged code. I just started a wiki page to document the code flags I've been using.
I've tested the point coordinate regulators on my machine, and they seem to work as expected!
I'm happy overall with the design of the new regulator. It seems to slot into the existing…