On the page you link, it does mention that in an impl block, Self is an abbreviation for the type being impled. So that suggests we could write […]. What do you think?
Oh, yes, we could do…
I think the second is to tie some methods to that datatype; is there no more compact syntax for doing so when you immediately want to tie some methods, as is very common?
I don't know of any…
That sounds fine. I've suggested some groupings for SceneSpheres::push and ScenePoints::push. Are there any…
why the semicolon now
The semicolon helps communicate the intent of the code, as explained below. I'm adding it now because I didn't notice it was missing until now, when I ran Rustfmt in…
What do you think?
I think that commas on every arm (as we now have) are much more readable than braces on…
elide the
_assembpart, and quite possibly all the commonload_parts, of these function names altogether
I agree that dropping the _assemb suffix makes sense now that we've split the…
is it legal in keyword arguments to have whitespace
For clarity: Rust does not currently have keyword arguments. The code you're looking at is…
but also see a later comment that another way to go at the moment might be to go ahead and group some of these option arguments onto a single line
Sure. Does either of the following groupings…
Yes, I think that revising the SceneSpheres and ScenePoints structures at some point would be a good idea.
But perhaps this PR is not the time to do it?
I agree. Like I said in the…
Now that we've switched to using commas after match arms wrapped in blocks, should I still remove the commas after catch-all match arms? That would make them the only match arms without commas,…
If the point is that a comma is required when the branch is an expression without braces and optional when the branch is enclosed in braces […]
Yes, that's the point.
[…] then I…
As you may recall, I am averse to typographical conventions that burn vertical lines of code with no content, because I find allowing more code semantics to fit on the screen at once to be an…