I think best to fix in this PR, on the principle of not merging known buggy states of the code.
Great—I'll try to think about this before our meeting, and we can talk about it if it turns…
Commenting the example assembly chooser reminded me that the branch to be pulled has one outstanding bug: the element list doesn't always update properly when you choose a different assembly. I'd…
Either 'column' or 'columnIndex' would be better.
I've switched to column_index
(in commit 7d6a394). To reduce clutter, I've kept index
in the parts of Assembly::realize
where the…
Yup. Stuff like "hello".to_string()
looked even weirder to me at first, but the Rust book authors seem to consider it the most idiomatic way of going in the other direction...
Done (in commit 0c8022d). I've named the color variables according to their roles, with cues about the intended color limited to brightness descriptions. There are comments describing the colors…
Done (in commit 2b083be). Would it be helpful to think about what a better solution might look like? I started using these temporary emoji icons precisely because it felt too early to think about…
I think I recall you saying—maybe during a meeting—that you'd like Element::index
to be renamed to something more descriptive, like col_index
or config_col
. If you do want that, let me…
Done! I've expanded "cst" to "constraint," "elt" to "element," and "rep" to "representation" in the HTML element classes (commits 882286c and 3f3c173).
These functions build the test assemblies we've been playing with: the "General" assembly that appears when you load the page, and the "Low-curvature" assembly that you can pick from the drop-down…
The main branch has diverged from the branch to be merged because of the changes we made to while reviewing #15. Those changes have been incorporated in #19, which supersedes this pull request.