Vectornaut
  • Joined on 2019-09-28
Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 19:32:05 +00:00
Clean up the outline view

I think best to fix in this PR, on the principle of not merging known buggy states of the code.

Great—I'll try to think about this before our meeting, and we can talk about it if it turns…

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 09:25:58 +00:00
Clean up the outline view

Commenting the example assembly chooser reminded me that the branch to be pulled has one outstanding bug: the element list doesn't always update properly when you choose a different assembly. I'd…

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 09:22:16 +00:00
Clean up the outline view

Either 'column' or 'columnIndex' would be better.

I've switched to column_index (in commit 7d6a394). To reduce clutter, I've kept index in the parts of Assembly::realize where the…

Vectornaut pushed to outline-cleanup_on_main at StudioInfinity/dyna3 2024-11-14 09:18:31 +00:00
7d6a394156 Name element column index more descriptively
Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 09:03:39 +00:00
Clean up the outline view

Done (in commit a48fef3).

Vectornaut pushed to outline-cleanup_on_main at StudioInfinity/dyna3 2024-11-14 09:01:41 +00:00
a48fef3641 Comment example assembly chooser
Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 08:35:43 +00:00
Clean up the outline view

Yup. Stuff like "hello".to_string() looked even weirder to me at first, but the Rust book authors seem to consider it the most idiomatic way of going in the other direction...

Vectornaut pushed to outline-cleanup_on_main at StudioInfinity/dyna3 2024-11-14 08:31:56 +00:00
2b083be998 Explain emoji icon kludge
0c8022d78e Give CSS colors meaningful names
Compare 2 commits »
Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 08:31:38 +00:00
Clean up the outline view

Done (in commit 0c8022d). I've named the color variables according to their roles, with cues about the intended color limited to brightness descriptions. There are comments describing the colors…

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 08:25:35 +00:00
Clean up the outline view

Done (in commit 2b083be). Would it be helpful to think about what a better solution might look like? I started using these temporary emoji icons precisely because it felt too early to think about…

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 08:22:09 +00:00
Clean up the outline view

Done (in commit 2b083be).

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 00:46:13 +00:00
Clean up the outline view

I think I recall you saying—maybe during a meeting—that you'd like Element::index to be renamed to something more descriptive, like col_index or config_col. If you do want that, let me…

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 00:42:33 +00:00
Clean up the outline view

Done! I've expanded "cst" to "constraint," "elt" to "element," and "rep" to "representation" in the HTML element classes (commits 882286c and 3f3c173).

Vectornaut pushed to outline-cleanup_on_main at StudioInfinity/dyna3 2024-11-14 00:41:37 +00:00
3f3c1739cb Write out "element" in HTML element classes
882286c0e3 Write out "constraint" in HTML element classes
Compare 2 commits »
Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 00:26:17 +00:00
Clean up the outline view

These functions build the test assemblies we've been playing with: the "General" assembly that appears when you load the page, and the "Low-curvature" assembly that you can pick from the drop-down…

Vectornaut commented on pull request StudioInfinity/dyna3#19 2024-11-14 00:16:08 +00:00
Clean up the outline view

The key method returns a String (a…

Vectornaut commented on pull request StudioInfinity/dyna3#16 2024-11-13 08:02:00 +00:00
WIP: Clean up the outline view

The main branch has diverged from the branch to be merged because of the changes we made to while reviewing #15. Those changes have been incorporated in #19, which supersedes this pull request.

Vectornaut closed pull request StudioInfinity/dyna3#16 2024-11-13 08:02:00 +00:00
WIP: Clean up the outline view
Vectornaut created pull request StudioInfinity/dyna3#19 2024-11-13 07:54:46 +00:00
Clean up the outline view
Vectornaut pushed to outline-cleanup_on_main at StudioInfinity/dyna3 2024-11-13 07:52:04 +00:00
b3470b597d Make Element::index private