Write a constructor for `Regulator`

Vectornaut commented

2025-01-25 20:53:16 +00:00

Member

As of #29, the + button in the AddRemove component is the only thing that can create a Constraint. A lot of the code it uses for this is general-purpose, and would fit nicely into the assembly module. This general-purpose code should be turned into an associated function of Constraint.

As of #29, the *+* button in the `AddRemove` component is the only thing that can create a `Constraint`. A lot of the code it uses for this is general-purpose, and would fit nicely into the `assembly` module. This general-purpose code should be turned into an associated function of `Constraint`.

glen commented

2025-02-18 03:10:10 +00:00

Owner

Should this be renamed "Write a constructor for Regulator"? Or is it now moot altogether?

Vectornaut commented

2025-02-18 05:58:45 +00:00

Author

Member

Yes, I think it should be renamed once #48 is merged. At that point, we could change the description to say "as of #48" and update to the terminology of #48.

glen changed title from ~~Write a constructor for Constraint~~ to Write a constructor for Regulator

2025-03-12 22:21:41 +00:00

glen commented

2025-03-12 22:36:02 +00:00

Owner

As AddRemove at this point only calls assembly.insert_new_regulator, I believe this is moot/complete, so closing. If there is anything further that needs to be done, please open a new issue with more details on the desired refactor.

👍 1

glen closed this issue

2025-03-12 22:36:02 +00:00

Rows
Columns

Write a constructor for Regulator #36

Write a constructor for `Regulator` #36