Vectornaut
  • Joined on 2019-09-28
Vectornaut commented on pull request glen/dyna3#22 2024-11-19 00:40:59 +00:00
Give each element a serial number

As far as I know, dyna3 should be single-threaded right now, so for parsimony we could instead store the next serial number in a thread-local cell, as suggested in [this other StackOverflow…

Vectornaut closed pull request glen/dyna3#21 2024-11-19 00:16:30 +00:00
Fix element list updates
Vectornaut commented on pull request glen/dyna3#21 2024-11-19 00:16:23 +00:00
Fix element list updates

As we discussed in our meeting today, this PR has been superseded by #22. I'm keeping the outline-update-fix branch in case we decide later that we'd rather use this alternate approach.

Vectornaut created pull request glen/dyna3#22 2024-11-19 00:14:22 +00:00
Give each element a serial number
Vectornaut created branch element-serial in glen/dyna3 2024-11-19 00:12:39 +00:00
Vectornaut pushed to element-serial at glen/dyna3 2024-11-19 00:12:39 +00:00
6b2d44a58c Assign each element a serial number
Vectornaut pushed to outline-update-fix at glen/dyna3 2024-11-18 19:50:06 +00:00
b479e57446 Start assembly serial number at zero
Vectornaut commented on pull request glen/dyna3#21 2024-11-18 19:45:50 +00:00
Fix element list updates

Whoops, I just remembered why I didn't store the serial number in the assembly. Right now, for simplicity, the application state just contains one fixed Assembly object. There's no code for…

Vectornaut commented on pull request glen/dyna3#21 2024-11-18 19:36:26 +00:00
Fix element list updates

If you'd prefer, you could just have each Assembly grab a serial number from the state when it is created

That would simplify the code a little, and it might have a slight advantage over…

Vectornaut created pull request glen/dyna3#21 2024-11-16 02:58:42 +00:00
Fix element list updates
Vectornaut created branch outline-update-fix in glen/dyna3 2024-11-16 02:44:27 +00:00
Vectornaut pushed to outline-update-fix at glen/dyna3 2024-11-16 02:44:27 +00:00
8daef5f71e Key element outline items by assembly
Vectornaut commented on pull request glen/dyna3#19 2024-11-15 01:14:31 +00:00
Clean up the outline view

We've decided to leave the element list update bug (#20) in this PR, and fix it in a subsequent PR.

Vectornaut opened issue glen/dyna3#20 2024-11-15 01:13:46 +00:00
Element list doesn't update properly when switching assemblies
Vectornaut commented on pull request glen/dyna3#19 2024-11-14 19:32:05 +00:00
Clean up the outline view

I think best to fix in this PR, on the principle of not merging known buggy states of the code.

Great—I'll try to think about this before our meeting, and we can talk about it if it turns…

Vectornaut commented on pull request glen/dyna3#19 2024-11-14 09:25:58 +00:00
Clean up the outline view

Commenting the example assembly chooser reminded me that the branch to be pulled has one outstanding bug: the element list doesn't always update properly when you choose a different assembly. I'd…

Vectornaut commented on pull request glen/dyna3#19 2024-11-14 09:22:16 +00:00
Clean up the outline view

Either 'column' or 'columnIndex' would be better.

I've switched to column_index (in commit 7d6a394). To reduce clutter, I've kept index in the parts of Assembly::realize where the…

Vectornaut pushed to outline-cleanup_on_main at glen/dyna3 2024-11-14 09:18:31 +00:00
7d6a394156 Name element column index more descriptively
Vectornaut commented on pull request glen/dyna3#19 2024-11-14 09:03:39 +00:00
Clean up the outline view

Done (in commit a48fef3).

Vectornaut pushed to outline-cleanup_on_main at glen/dyna3 2024-11-14 09:01:41 +00:00
a48fef3641 Comment example assembly chooser