As far as I know, dyna3
should be single-threaded right now, so for parsimony we could instead store the next serial number in a thread-local cell, as suggested in [this other StackOverflow…
As we discussed in our meeting today, this PR has been superseded by #22. I'm keeping the outline-update-fix
branch in case we decide later that we'd rather use this alternate approach.
Whoops, I just remembered why I didn't store the serial number in the assembly. Right now, for simplicity, the application state just contains one fixed Assembly
object. There's no code for…
If you'd prefer, you could just have each Assembly grab a serial number from the state when it is created
That would simplify the code a little, and it might have a slight advantage over…
We've decided to leave the element list update bug (#20) in this PR, and fix it in a subsequent PR.
I think best to fix in this PR, on the principle of not merging known buggy states of the code.
Great—I'll try to think about this before our meeting, and we can talk about it if it turns…
Commenting the example assembly chooser reminded me that the branch to be pulled has one outstanding bug: the element list doesn't always update properly when you choose a different assembly. I'd…
Either 'column' or 'columnIndex' would be better.
I've switched to column_index
(in commit 7d6a394). To reduce clutter, I've kept index
in the parts of Assembly::realize
where the…