I can revert all these changes, and do a PR after the whitespace one fixing all the 80-character violations in the whole code base. Ok?
Making a later pull request to impose a consistent line…
A much stronger convention, universal among all projects I have ever worked on, is no trailing whitespace (on any line).
This is the convention the [Rust style guide](https://doc.rust-lang.org…
To me, the placement of the new helper is kind of weird to me. It's right in the middle of the Sphere definition and implementation section, which makes it seem associated with Sphere, when in…
The helper is useful, and I like the more informative error messages! To help make it clear how the helper is supposed to be used, I might make some or all of the following changes.
- Add more…
I'll trust your experience with installing Cargo tools at custom locations, since I've never tried it!
The information here looks accurate to me, although I've never installed a global tool with the --locked flag, and I don't know whether it's recommended.
@glen wrote in StudioInfinity/dyna3#118 (comment):
It took me a while to figure out how to deal with it, so I made a couple small changes in the…
Thanks for reflowing and rewording the comment!
Actually there are many 80-character line violations; again, I didn't realize. I will fix the ones in this source file, and we can fix other…
Whoops, here's a formatting mistake from the revision I made. I should've just written
I'd be fine with leaving it out of this pull request. I made it because this pull request implements Display for Axis using the terser fmt::Result convention, and I wanted the previous…
Our current convention is that all the lines in a block, including blank lines, should have the block indentation. Under that convention, this blank line would need to be indented by four spaces, just like the lines above and below it and the other blank lines within the same impl block.
I've been wrapping comments at 80 characters throughout the code. Under that convention, this comment would need to be reflowed.
For consistency with InversiveDistanceRegulator, I'd change the panic message to:
Here are the error message and formatting changes that I'd most strongly like to apply from my reverted "spruce up" commit.
This spacing convention is widely used in Rust code, and it's recommended in the Rust style guide:
For a single-line…
Any chance we could just unwind that commit, and then if there are a handful of individual formatting things that you think are particularly problematic, you enter them as review comments for me…
since the PR didn't create the bug, just gave us a way for the first time to trigger it, I have no problem with your filing an issue and merging this without fixing the bug.
Great. I just…