Now that I've merged pull request #81, the branch for this pull request (curvature-regulators) needs to be rebased onto main.
Or maybe not! I just noticed that the merge control panel says…
Now that I've merged pull request #81, the branch for this pull request (curvature-regulators) needs to be rebased onto main. If I'm the only one with a local copy of this branch, I'd be happy…
I've made the changes we discussed during our meeting:
- Use field init shorthand in the regulator…
We approved my revisions during today's meeting, so I'll merge!
If you're happy with the revisions I made in commit 664b3d8, I'll go ahead and merge.
I haven't figured out how to do it with cargo test, however.
I think the right way to do this would be to use the [-C flag](https://doc.rust-lang.org/cargo/commands/cargo-test.html#common-op…
This is useful information, and it works on my system. I've streamlined the instructions a bit (commit 664b3d8) using the fact that only one step depends on which folder you're in.
I used this organization so that problem could be immutable in the scope where it's used, and only mutable in the scope where it's created.
This one is intended to be an inversive distance regulator.
Renamed (commit 620a6be). I think the code is ready for review again now.
Done (commits ee8a01b – 52d9975). To me, the code that creates and inserts regulators looks much better-organized now!
Done, by making CURVATURE_COMPONENT an associated constant of the Element structure (commit 7f21e7e). When we introduce separate structures for different kinds of elements, this one will go in…
I also just realized that the names of the two regulators are not parallel: currently they are "HalfCurvatureRegulator" and "ProductRegulator". The first is geometry-centric, the second is…
But such code should be part of the code for that flavor of regulator, not in an "outside" method like this insertion gadget.
I think that's a great idea. I propose moving the insertion code…
I've made the changes we discussed during our last meeting, so this should be ready for review again!