Correct the rest of the test assembly loading scripts #161

Merged

glen merged 2 commits from Vectornaut/dyna3:loading-script-fixes into main

2026-06-23 21:02:54 +00:00

Vectornaut commented

2026-06-23 18:43:29 +00:00

Member

In pull request #155, we stopped accepting arguments for the Sphere and Point descriptors. As a result, interpretation began to fail for test assembly loading scripts with missing newlines (as it always should have). We added the needed newlines to the loading script for the "Pointed" test assembly, but didn't notice that newlines were also missing from the loading scripts for the "Dodecahedral packing," "Radius ratio," and "Irisawa hexlet" test assemblies. This pull request adds the needed newlines to those loading scripts.

This pull request also addresses issue #157 by adding tests that make sure the test assembly loading scripts can be interpreted and run. When we start reading the test assembly loading scripts from files, rather than building them into the executable, these tests will need to be rewritten. However, the loading script errors that slipped through review in pull request #155 suggest that it's worth addressing #157 sooner rather than later.

In pull request #155, we stopped accepting arguments for the `Sphere` and `Point` descriptors. As a result, interpretation began to fail for test assembly loading scripts with missing newlines (as it always should have). We added the needed newlines to the loading script for the "Pointed" test assembly, but didn't notice that newlines were also missing from the loading scripts for the "Dodecahedral packing," "Radius ratio," and "Irisawa hexlet" test assemblies. This pull request adds the needed newlines to those loading scripts. This pull request also addresses issue #157 by adding tests that make sure the test assembly loading scripts can be interpreted and run. When we start reading the test assembly loading scripts from files, rather than building them into the executable, these tests will need to be rewritten. However, the loading script errors that slipped through review in pull request #155 suggest that it's worth addressing #157 sooner rather than later.

Vectornaut added 2 commits

2026-06-23 18:43:29 +00:00