StudioInfinity/dyna3
2
0
Fork 2
Code Issues 57 Pull requests 1 Projects 3 Releases 4 Wiki Activity Actions

Simplify the realization triggering system #105

Merged
glen merged 6 commits from Vectornaut/dyna3:reactive-realization-cleanup into main 2025-07-31 22:21:34 +00:00
Conversation 2 Commits 6 Files changed 4 +10
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 03d6cf0687 - Show all commits

10
app-proto/src/components/add_remove.rs
View file

@ -18,6 +18,16 @@ pub fn AddRemove() -> View {
// this call is batched to avoid redundant realizations. // this call is batched to avoid redundant realizations.
// it updates the element list and the regulator list, // it updates the element list and the regulator list,
// which are both tracked by the realization effect // which are both tracked by the realization effect
/* TO DO */
// it would make more to do the batching inside
// `insert_element_default`, but that will have to wait
// until Sycamore handles nested batches correctly.
//
// https://github.com/sycamore-rs/sycamore/issues/802
//
// the nested batch issue is relevant here because the
// assembly loaders in the test assembly chooser use
// `insert_element_default` within larger batches
state.assembly.insert_element_default::<Sphere>(); state.assembly.insert_element_default::<Sphere>();
}); });
} }