Ctrl-C/Ctrl X should apply to current cell when there is no selection. #28

New Issue

glen · 2019-07-25T12:48:10Z

glen commented

2019-07-25 12:48:10 +00:00

Subject says it all.

glen referenced this issue from a commit

2019-07-27 04:31:07 +00:00

A first stab at refactoring In general, the goal of these changes is to be more type-specific wherever possible, reduce duplicated code, and avoid magic numbers. The biggest individual change is to use Location triples of integers wherever possible rather than three separate int variables. Another very helpful change for understanding what is going on in the code is introducing the MarkState enum for tracking the process of marking and unmarking blocks of cell. The MarkState change was motivated by the issues with Ctrl-C, and this commit, in fact, resolves #28. Because of the lack of a test harness, it is possible that a change of this scope has created some bugs as well, but teapot was running OK for me at the time of the commit. However, I don't know how good my coverage of the changed code was -- I certainly did not save or load a Lotus 1-2-3 file!

glen closed this issue

2019-07-27 04:31:07 +00:00

glen commented

2019-07-27 04:33:06 +00:00

Although the recent commit does allow you to do Ctrl-C and Ctrl V on single cells, it's still a bit klunky in that it leaves the cell marked at the end after the paste, and I think you have to confirm the operation. So there may need to be a follow-on issue at some point.

Sign in to join this conversation.