Clocking restores previously reset content #18

New Issue

glen · 2019-07-23T19:23:27Z

glen commented

2019-07-23 19:23:27 +00:00

Open the "life.tp" example file. Clock forward ten or so steps. Reset the sheet. Clock forward one step. Ugh, there are TWO gliders, not one; the second is one step ahead of the old one just before it was cleared.

glen added the

bug

label 2019-07-23 19:23:27 +00:00

glen added the

Serious

label 2019-07-23 19:24:51 +00:00

glen referenced this issue from a commit

2019-07-24 17:58:53 +00:00

Prevent phantom values when clocking, resetting, and clocking again In the end it turned out that the cause of the phantom values was short-cutting in getvalue() when the contents of a cell were empty, preventing the update of the internal cache of the value of the cell. However, tracking this down (and getting the associated memory management correct) necessitated implementing a debugging mode in which I could dump the internal states of cells and print various other stuff to standard output. It also involved understanding the meaning of various pointers in the code, in the process of which I renamed some commonly used macros, particularly the former SHEET(s,x,y,z) which was not returning a Sheet at all but rather a pointer to a Cell. So this macro is now called CELL_AT. I also replaced several very repeatedly used patterns of checking the validity of locations and pointers with macros, now defined in sheet.h. Therefore, unfortunately the (relatively small in the end) bugfix for this major issue is entangled with numerous textual changes to the code made in tracking it down. Fixes #18. Closes #19.

glen closed this issue

2019-07-24 17:58:53 +00:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: glen/teapot-spreadsheet#18