glen/dyna3
1
0
Fork 1
Code Issues 26 Pull requests 1 Projects 1 Releases 2 Wiki Activity Actions

Use workaround to keep representation coordinates in order #46

Merged
glen merged 1 commit from Vectornaut/dyna3:rep-disp-order_on_main into main 2025-02-08 06:08:37 +00:00
Conversation 0 Commits 1 Files changed 1 +11 -13
Vectornaut commented 2025-02-07 19:24:26 +00:00
Collaborator
Copy link

This fixes #41 by rendering representation vectors with a static list view rather than an Indexed view. The Sycamore maintainer has confirmed that Indexed is always supposed to display list items in order, so I think #41 is likely caused by a bug in Indexed. We should consider reverting this pull request when the bug is fixed.

This fixes #41 by rendering representation vectors with a static list view rather than an `Indexed` view. The Sycamore maintainer has confirmed that `Indexed` is always supposed to display list items in order, so I think #41 is likely caused by a bug in `Indexed`. We should consider reverting this pull request when the bug is fixed.
Vectornaut added 1 commit 2025-02-07 19:24:27 +00:00 
The `Indexed` used in the previous commit would occasionally put the
coordinates out of order. I don't know why it did that, but this view
always keeps the coordinates in order, and it might be more efficient
anyway.
glen merged commit 46324fecc6 into main 2025-02-08 06:08:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
prospective

this becomes an issue once a particular feature is implemented or pull request is merged

  
question

More information is needed

  
todo

Planned step in implementation

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
prospective
question
todo
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: glen/dyna3#46
No description provided.
Delete branch "Vectornaut/dyna3:rep-disp-order_on_main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?