glen/dyna3
1
0
Fork 0
Code Issues 11 Pull Requests 1 Actions Projects Releases 2 Wiki Activity

Clean up the outline view #19

Merged
glen merged 23 commits from outline-cleanup_on_main into main 2024-11-15 03:32:48 +00:00
Conversation 9 Commits 23 Files Changed 7 +10
3 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4ecb39e73a - Show all commits

2
app-proto/index.html
View File

@ -4,6 +4,8 @@
<meta charset="utf-8"/> <meta charset="utf-8"/>
<title>dyna3</title> <title>dyna3</title>
<link data-trunk rel="css" href="main.css"/> <link data-trunk rel="css" href="main.css"/>
<link href="https://fonts.bunny.net/css?family=lato:ital,wght@0,400;1,400&display=swap" rel="stylesheet">
<link href="https://fonts.bunny.net/css?family=noto-emoji:wght@400&text=%f0%9f%94%97%e2%9a%a0&display=swap" rel="stylesheet">
</head> </head>
<body></body> <body></body>
</html> </html>

7
app-proto/main.css
View File

@ -2,6 +2,7 @@ body {
margin: 0px; margin: 0px;
color: #fcfcfc; color: #fcfcfc;
background-color: #222; background-color: #222;
font-family: 'Lato';
} }
/* sidebar */ /* sidebar */
@ -33,6 +34,11 @@ body {
font-size: large; font-size: large;
} }
/* KLUDGE */
#add-remove > button.emoji {
glen marked this conversation as resolved Outdated
glen commented 2024-11-13 17:43:38 +00:00
Outdated
Review
Copy Link

Just the word "KLUDGE" is not helpful to a future maintainer (who might not be you). Please explain the concern, say a word about how this sidesteps it, and say a word about what a better solution might look like.

Just the word "KLUDGE" is not helpful to a future maintainer (who might not be you). Please explain the concern, say a word about how this sidesteps it, and say a word about what a better solution might look like.
👍 1
Vectornaut commented 2024-11-14 08:25:35 +00:00
Outdated
Review
Copy Link

Done (in commit 2b083be). Would it be helpful to think about what a better solution might look like? I started using these temporary emoji icons precisely because it felt too early to think about polishing the icons.

Done (in commit 2b083be). Would it be helpful to think about what a better solution might look like? I started using these temporary emoji icons precisely because it felt too early to think about polishing the icons.
glen commented 2024-11-14 15:47:13 +00:00
Outdated
Review
Copy Link

No need. Emoji and/or appropriate Unicode characters could be perfectly OK long-term solutions, as they are becoming part of society's visual vernacular.

No need. Emoji and/or appropriate Unicode characters could be perfectly OK long-term solutions, as they are becoming part of society's visual vernacular.
font-family: 'Noto Emoji';
}
/* outline */ /* outline */
#outline { #outline {
@ -127,6 +133,7 @@ details[open]:has(li) .elt-switch::after {
width: 20px; width: 20px;
padding-left: 4px; padding-left: 4px;
text-align: center; text-align: center;
font-family: 'Noto Emoji';
font-style: normal; font-style: normal;
} }

1
app-proto/src/add_remove.rs
View File

@ -202,6 +202,7 @@ pub fn AddRemove() -> View {
} }
) { "+" } ) { "+" }
button( button(
class="emoji", /* KLUDGE */
disabled={ disabled={
let state = use_context::<AppState>(); let state = use_context::<AppState>();
state.selection.with(|sel| sel.len() != 2) state.selection.with(|sel| sel.len() != 2)