glen/dyna3
1
0
Fork 0
Code Issues 11 Pull Requests 1 Actions Projects Releases 2 Wiki Activity

WIP: Clean up the outline view #16

Closed
Vectornaut wants to merge 29 commits from outline-cleanup into main
pull from: outline-cleanup
merge into: glen:main
Conversation 2 Commits 29 Files Changed 13 +14 -21
1 changed files with 14 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bbeebe4464 - Show all commits

35
app-proto/src/outline.rs
View File

@ -43,13 +43,9 @@ fn ConstraintOutlineItem(constraint_key: usize, element_key: usize) -> View {
constraint.args.0
};
let other_arg_label = assembly.elements.with(|elts| elts[other_arg].label.clone());
let class = create_memo(move || {
if constraint.rep_valid.get() {
"cst"
} else {
"cst invalid"
}
});
let class = constraint.rep_valid.map(
|&rep_valid| if rep_valid { "cst" } else { "cst invalid" }
);
view! {
li(class=class.get()) {
input(r#type="checkbox", bind:checked=constraint.active)
@ -64,13 +60,9 @@ fn ConstraintOutlineItem(constraint_key: usize, element_key: usize) -> View {
#[component(inline_props)]
fn ElementOutlineItem(key: usize, element: assembly::Element) -> View {
let state = use_context::<AppState>();
let class = create_memo(move || {
if state.selection.with(|sel| sel.contains(&key)) {
"selected"
} else {
""
}
});
let class = state.selection.map(
move |sel| if sel.contains(&key) { "selected" } else { "" }
);
let label = element.label.clone();
let rep_components = element.rep.iter().map(|u| {
let u_coord = format!("{:.3}", u).replace("-", "\u{2212}");
@ -176,15 +168,16 @@ fn ElementOutlineItem(key: usize, element: assembly::Element) -> View {
//
#[component]
pub fn Outline() -> View {
// sort the elements alphabetically by ID
let elements_sorted = create_memo(|| {
let state = use_context::<AppState>();
state.assembly.elements
.get_clone()
let state = use_context::<AppState>();
// list the elements alphabetically by ID
let element_list = state.assembly.elements.map(
|elts| elts
.clone()
.into_iter()
.sorted_by_key(|(_, elt)| elt.id.clone())
.collect()
});
);
view! {
ul(
@ -195,7 +188,7 @@ pub fn Outline() -> View {
}
) {
Keyed(
list=elements_sorted,
list=element_list,
view=|(key, elt)| view! {
ElementOutlineItem(key=key, element=elt)
},