glen/dyna3
1
0
Fork 0
Code Issues 11 Pull Requests 1 Actions Projects Releases 2 Wiki Activity

Integrate engine into application prototype #15

Merged
glen merged 24 commits from engine-integration into main 2024-11-12 00:46:16 +00:00
Conversation 15 Commits 24 Files Changed 14 +4 -4
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9c191ae586 - Show all commits

4
app-proto/src/add_remove.rs
View File

@ -228,7 +228,7 @@ pub fn AddRemove() -> View {
/* DEBUG */ /* DEBUG */
// print updated constraint list // print updated constraint list
console::log_1(&JsValue::from("constraints:")); console::log_1(&JsValue::from("Constraints:"));
state.assembly.constraints.with(|csts| { state.assembly.constraints.with(|csts| {
for (_, cst) in csts.into_iter() { for (_, cst) in csts.into_iter() {
console::log_5( console::log_5(
@ -246,7 +246,7 @@ pub fn AddRemove() -> View {
create_effect(move || { create_effect(move || {
rep.track(); rep.track();
console::log_2( console::log_2(
&JsValue::from("Constraint rep updated to"), &JsValue::from("Lorentz product updated to"),
&JsValue::from(rep.get_untracked()) &JsValue::from(rep.get_untracked())
); );
if active.get() { if active.get() {

2
app-proto/src/assembly.rs
View File

@ -146,7 +146,7 @@ impl Assembly {
/* DEBUG */ /* DEBUG */
// log the initial configuration matrix // log the initial configuration matrix
console::log_1(&JsValue::from("old configuration:")); console::log_1(&JsValue::from("Old configuration:"));
glen marked this conversation as resolved Outdated
glen commented 2024-11-10 00:35:53 +00:00
Outdated
Review
Copy Link

Do you want to set up now a logging/debugging system so that we can leave messages like this in/out at compile time (so that they have no runtime impact when left out), and so always leave them in the code in the repo? Or do you think the project is premature for that, we will plan to take these out in the fairly near future? Either way is fine, just let me know; I am just making the point that we definitely don't want any raw console logs in our standard code, ultimately.

Do you want to set up now a logging/debugging system so that we can leave messages like this in/out at compile time (so that they have no runtime impact when left out), and so always leave them in the code in the repo? Or do you think the project is premature for that, we will plan to take these out in the fairly near future? Either way is fine, just let me know; I am just making the point that we definitely don't want any raw console logs in our standard code, ultimately.
👍 1
Vectornaut commented 2024-11-11 05:33:20 +00:00
Outdated
Review
Copy Link

I think it's too early to design a formal logging system. I've been adding and removing log messages pretty freely as I test new features and track down bugs. I just started a wiki page where we can jot down log messages that come in handy; we can refer to that list when we start thinking about how to log stuff more formally.

I think it's too early to design a formal logging system. I've been adding and removing log messages pretty freely as I test new features and track down bugs. I just started a [wiki page](wiki/Logging) where we can jot down log messages that come in handy; we can refer to that list when we start thinking about how to log stuff more formally.
for j in 0..guess.nrows() { for j in 0..guess.nrows() {
let mut row_str = String::new(); let mut row_str = String::new();
for k in 0..guess.ncols() { for k in 0..guess.ncols() {

2
app-proto/src/engine.rs
View File

@ -60,7 +60,7 @@ impl PartialMatrix {
pub fn log_to_console(&self) { pub fn log_to_console(&self) {
let PartialMatrix(entries) = self; let PartialMatrix(entries) = self;
for ent in entries { for ent in entries {
let ent_str = format!("{} {} {}", ent.index.0, ent.index.1, ent.value); let ent_str = format!(" {} {} {}", ent.index.0, ent.index.1, ent.value);
console::log_1(&JsValue::from(ent_str.as_str())); console::log_1(&JsValue::from(ent_str.as_str()));
} }
} }