Tidy up engine tests #64

New issue

Open

opened 2025-02-27 21:14:28 +00:00 by Vectornaut · 0 comments

Vectornaut commented

2025-02-27 21:14:28 +00:00

Collaborator

`zero_loss_test`

Drop the redundant type hint in the definition of a

`tangent_test`

Rename to tangent_test_three_spheres to make room for a kaleidocycle tangent test (done in #34).
Turn the ELEMENT_DIM and ASSEMBLY_DIM constants into parameters read off from the guess (done in #34).
Don't bother packing and unpacking the uniform motions into a matrix (done in #34).
Get the dimension from the expected basis, rather than putting it in by hand.

`tangent_test_kaleidocycle`

Factor out the realization code, in the same style as realize_irisawa_hexlet.
Rename the irisawa submodule to examples.

`frozen_entry_test`

Move up into the section for simpler tests, between zero_loss_test and irisawa_hexlet_test.

### `zero_loss_test` - [ ] Drop the redundant type hint in the definition of `a` ### `tangent_test` - [x] Rename to `tangent_test_three_spheres` to make room for a kaleidocycle tangent test *(done in #34)*. - [x] Turn the `ELEMENT_DIM` and `ASSEMBLY_DIM` constants into parameters read off from the guess *(done in #34)*. - [x] Don't bother packing and unpacking the uniform motions into a matrix *(done in #34)*. - [ ] Get the dimension from the expected basis, rather than putting it in by hand. ### `tangent_test_kaleidocycle` - [ ] Factor out the realization code, in the same style as `realize_irisawa_hexlet`. - [ ] Rename the `irisawa` submodule to `examples`. ### `frozen_entry_test` - [ ] Move up into the section for simpler tests, between `zero_loss_test` and `irisawa_hexlet_test`.