Element list doesn't fully update when switching assemblies #20

New Issue

Vectornaut · 2024-11-15T01:13:46Z

Vectornaut commented

2024-11-15 01:13:46 +00:00

Summary

Each item in a Sycamore keyed list is assigned a diff key. During a list update, when Sycamore sees an item whose diff key matches an item that's already on the list, it doesn't bother re-rendering that item.

In the outline view, the diff key we assign to an element or constraint is the slab key we use to access that element or constraint within the current assembly. As a result, elements in different assemblies can have matching diff keys.

The assembly switcher clears the previous assembly and builds the new assembly all in one update. When an element of the new assembly happens to have the same diff key as an element of the previous assembly, Sycamore doesn't re-render that item. Instead, it keeps showing the element of the previous assembly.

Reproduction

To see this happen, try switching from the "General' example to the "Low-curvature" example immediately after loading the page. Most of the element labels will stay the same—but the two examples don't actually have any labels in common.

## Summary Each item in a Sycamore keyed list is assigned a diff key. During a list update, when Sycamore sees an item whose diff key matches an item that's already on the list, it doesn't bother re-rendering that item. In the outline view, the diff key we assign to an element or constraint is the slab key we use to access that element or constraint within the current assembly. As a result, elements in different assemblies can have matching diff keys. The assembly switcher clears the previous assembly and builds the new assembly all in one update. When an element of the new assembly happens to have the same diff key as an element of the previous assembly, Sycamore doesn't re-render that item. Instead, it keeps showing the element of the previous assembly. ## Reproduction To see this happen, try switching from the "General' example to the "Low-curvature" example immediately after loading the page. Most of the element labels will stay the same—but the two examples don't actually have any labels in common.

Vectornaut changed title from ~~Element list doesn't update properly when switching assemblies~~ to Element list doesn't fully update when switching assemblies

2024-11-15 01:14:03 +00:00

Vectornaut referenced this issue

2024-11-15 01:14:31 +00:00

Clean up the outline view #19

glen referenced this issue from a commit

2024-11-15 03:32:50 +00:00

Clean up the outline view (#19)

Vectornaut referenced this issue

2024-11-16 02:58:41 +00:00

Fix element list updates #21

Sign in to join this conversation.