glen/dyna3
1
0
Fork 0
Code Issues 11 Pull Requests Actions Projects Releases 2 Wiki Activity

Assembly: don't track element list when inserting

Browse Source 
Calling `try_insert_element` or `insert_new_element` in a responsive
context shouldn't make the context track `elements_by_id`.
This commit is contained in:
Aaron Fenyes 2024-09-28 18:49:17 -07:00
parent 4f8f36053f
commit 721a8716d4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app-proto/full-interface/src/assembly.rs
View File

@ -49,7 +49,7 @@ impl Assembly {
} }
pub fn try_insert_element(&self, elt: Element) -> bool { pub fn try_insert_element(&self, elt: Element) -> bool {
let can_insert = self.elements_by_id.with( let can_insert = self.elements_by_id.with_untracked(
|elts_by_id| !elts_by_id.contains_key(&elt.id) |elts_by_id| !elts_by_id.contains_key(&elt.id)
); );
if can_insert { if can_insert {
@ -62,7 +62,7 @@ impl Assembly {
// find the next unused identifier in the default sequence // find the next unused identifier in the default sequence
let mut id_num = 1; let mut id_num = 1;
let mut id = format!("sphere{}", id_num); let mut id = format!("sphere{}", id_num);
while self.elements_by_id.with( while self.elements_by_id.with_untracked(
|elts_by_id| elts_by_id.contains_key(&id) |elts_by_id| elts_by_id.contains_key(&id)
) { ) {
id_num += 1; id_num += 1;