A) Seems like there is some duplication at least of structure/behavior here with the insert_new_product_regulator; is there anything that can be profitable factored out (some common insert_regula…
It also seems to me that Elements are ProblemPosers as well, but it's fine if that's not reflected in the software structure in this PR -- but you may want to contemplate that for #27.
Yes,…
I've fixed the example switcher regression and removed the work-in-progress flag! (The example switcher is now equally buggy on the main branch and on the branch to be merged. I'm not sure whether…
I've marked this PR as a work in progress because the example switcher is broken as of commit 81e423f. You're welcome to start reviewing while I debug the example switcher, because I expect the…
During review of #75, we decided to bundle all three checks together under cargo test
, both in continuous integration and during local development. We can get granular information about failures…
I am presuming this scheme has no WASM-bundle footprint when compiled for deployment.
That's right. If I've set things up right, tests and examples are conditionally compiled, so they won't…
No, I have now updated the "branch protection" settings for the repository so that if /test is failing, merge is not allowed.
Awesome. I've confirmed that I'm blocked from merging too.
Oops, I can still merge this PR even in a failing state. I will try to adjust the settings.
While you look at the repository settings (or review efb2d39 and 440b1df), I'll check whether this…
It's not too big a deal either way since I can't imagine either of us merging a failing PR. but do feel free to commit and revert a bad commit to check if you like. Just let me know whether you…
What I meant was: it was our intention that trunk be installed in a directory ci-bin created at the top level of the project hierarchy.
Got it! It turns out that the setup-trunk
action…
The GitHub Actions documentation is clearer about [how the path to a local action is specified](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using…