Vectornaut
  • Joined on 2019-09-28
Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-29 20:52:35 +00:00
Simplify the realization triggering system

So yes go ahead and leave the special case for empty assemblies; please just add a comment as to why it must be handled specially. Thanks!

Done in commit 779c026!

Vectornaut pushed to reactive-realization-cleanup at Vectornaut/dyna3 2025-07-29 20:48:49 +00:00
779c0260bb Explain why the empty-assembly case is special
Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-29 17:19:59 +00:00
Simplify the realization triggering system

How do those differ? When there are no elements, the whole configuration vector space is the zero space...

Good point: in principle, a ConfigSubspace variant representing a full subspace…

Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-29 08:07:06 +00:00
Simplify the realization triggering system

I've dropped the eigenvalue logging code (in commit eafb133) and filed an issue (#106) to remind us to replace it.

Vectornaut opened issue StudioInfinity/dyna3#106 2025-07-29 08:05:03 +00:00
Add tangent space determiners to the diagnostics panel
Vectornaut pushed to reactive-realization-cleanup at Vectornaut/dyna3 2025-07-29 07:45:52 +00:00
eafb133f8d Drop eigenvalue logging from symmetric_kernel
Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-28 21:55:26 +00:00
Simplify the realization triggering system

Any reason not to go ahead and do that in this PR?

On second thought, we'd actually have to use a separate conditional for the unconstrained case, because the tangent space would be…

Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-28 21:20:13 +00:00
Simplify the realization triggering system

I'm fine with dropping the eigenvalue logging now and replacing it with a diagnostics panel plot later—either in a stand-alone pull request or as part of a pull request that revises `ConfigSubspa…

Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-28 17:57:18 +00:00
Simplify the realization triggering system

(a) Why do we now need an empty-assembly special case, when we didn't before? Or is it just for efficiency?

The realization triggering system on the main branch never tries to realize an…

Vectornaut pushed to reactive-realization-cleanup at Vectornaut/dyna3 2025-07-28 17:46:11 +00:00
ca57fbce86 Correct the indentation of an empty line
Vectornaut commented on pull request StudioInfinity/dyna3#105 2025-07-28 17:24:19 +00:00
Simplify the realization triggering system

What does this #-directive do? Not compile the next line if this is not a "dev" compile?

Correct, if you replace "not compile" with "only compile" (I think this was a typo, based on your next…

Vectornaut pushed to reactive-realization-cleanup at Vectornaut/dyna3 2025-07-24 23:33:16 +00:00
2bae8d3df9 Prevent unused imports for engine debug output
03d6cf0687 Flag our workaround for a Sycamore batching bug
Compare 2 commits »
Vectornaut pushed to reactive-realization-cleanup at Vectornaut/dyna3 2025-07-24 22:23:45 +00:00
c73008d702 Trigger realization more directly
Vectornaut created pull request StudioInfinity/dyna3#105 2025-07-24 22:19:58 +00:00
Simplify the realization triggering system
Vectornaut created branch reactive-realization-cleanup in Vectornaut/dyna3 2025-07-24 22:00:04 +00:00
Vectornaut pushed to reactive-realization-cleanup at Vectornaut/dyna3 2025-07-24 22:00:04 +00:00
3eddef784b Trigger realization more directly
Vectornaut pushed to main at Vectornaut/dyna3 2025-07-22 23:22:52 +00:00
0801200210 Add more test assemblies (#103)
Vectornaut commented on issue StudioInfinity/dyna3#104 2025-07-22 22:29:42 +00:00
Tridiminished icosahedron: line search failed

@glen wrote in StudioInfinity/dyna3#104 (comment):

OK, worked this time. Perhaps the first time I accidentally put a -0.25 into one of the A-C…

Vectornaut commented on issue StudioInfinity/dyna3#104 2025-07-22 22:12:56 +00:00
Tridiminished icosahedron: line search failed

To help check whether we're following the same procedure: I'm setting distances in this order.

From

Vectornaut commented on issue StudioInfinity/dyna3#104 2025-07-22 22:03:01 +00:00
Tridiminished icosahedron: line search failed

Huh: I don't get a line search failure. In fact, once I've set all the inversive distances except the A–C ones, I find that the A–C ones already have the desired values. This is consistent…