Vectornaut
  • Joined on 2019-09-28
Vectornaut created branch select-in-display in StudioInfinity/dyna3 2024-11-26 03:01:41 +00:00
Vectornaut pushed to select-in-display at StudioInfinity/dyna3 2024-11-26 03:01:41 +00:00
f4c9d3d7f4 App: factor out the selection routine
17d4ed86e4 Display: click to select spheres
Compare 2 commits »
Vectornaut commented on pull request StudioInfinity/dyna3#24 2024-11-25 09:41:54 +00:00
Turn non-automated tests into Cargo examples

One of the above needs to be done. You are also encouraged either in the README to acknowledge app-proto and quickly mention how to run the prototype app [...] and how to run the examples, or…

Vectornaut pushed to cargo-examples_on_main at StudioInfinity/dyna3 2024-11-25 09:39:27 +00:00
dc5020752b Say how to run the prototype, examples, and tests
Vectornaut created pull request StudioInfinity/dyna3#24 2024-11-22 04:39:34 +00:00
Turn non-automated tests into Cargo examples
Vectornaut created branch cargo-examples_on_main in StudioInfinity/dyna3 2024-11-22 04:35:41 +00:00
Vectornaut pushed to cargo-examples_on_main at StudioInfinity/dyna3 2024-11-22 04:35:41 +00:00
848f7d665b Rename the dev feature to reflect its generality
b23d4a1860 Separate test and example for Irisawa hexlet
de8c662de4 Factor out the realization of the Irisawa hexlet
e69073a996 Streamline Gram matrix setup for Irisawa hexlet
519d0f49df Turn assertionless tests into Cargo examples
Compare 5 commits »
Vectornaut commented on pull request StudioInfinity/dyna3#22 2024-11-22 00:50:08 +00:00
Give each element a serial number

As discussed in our meeting, I've gone back to the atomic version, with one change: we now panic when we run out of serial numbers, rather than silently wrapping around. Ready to review again!

Vectornaut pushed to element-serial at StudioInfinity/dyna3 2024-11-22 00:47:55 +00:00
a5fd6545e0 Remove caveat about NEXT_ELEMENT_SERIAL wrapping
Vectornaut pushed to element-serial at StudioInfinity/dyna3 2024-11-22 00:42:56 +00:00
133b725053 Panic if we run out of serial numbers
c5f09b99b3 Add reminder to reconsider global element serials
b0bd31a9da Go back to atomic for next element serial number
Compare 3 commits »
Vectornaut commented on pull request StudioInfinity/dyna3#22 2024-11-19 04:31:51 +00:00
Give each element a serial number

As discussed over e-mail, we'll go with the thread-local version for now. Ready to review!

Vectornaut pushed to element-serial at StudioInfinity/dyna3 2024-11-19 04:30:10 +00:00
7bc3a9eeae Make the next element serial number thread-local
Vectornaut commented on pull request StudioInfinity/dyna3#22 2024-11-19 00:40:59 +00:00
Give each element a serial number

As far as I know, dyna3 should be single-threaded right now, so for parsimony we could instead store the next serial number in a thread-local cell, as suggested in [this other StackOverflow…

Vectornaut closed pull request StudioInfinity/dyna3#21 2024-11-19 00:16:30 +00:00
Fix element list updates
Vectornaut commented on pull request StudioInfinity/dyna3#21 2024-11-19 00:16:23 +00:00
Fix element list updates

As we discussed in our meeting today, this PR has been superseded by #22. I'm keeping the outline-update-fix branch in case we decide later that we'd rather use this alternate approach.

Vectornaut created pull request StudioInfinity/dyna3#22 2024-11-19 00:14:22 +00:00
Give each element a serial number
Vectornaut created branch element-serial in StudioInfinity/dyna3 2024-11-19 00:12:39 +00:00
Vectornaut pushed to element-serial at StudioInfinity/dyna3 2024-11-19 00:12:39 +00:00
6b2d44a58c Assign each element a serial number
Vectornaut pushed to outline-update-fix at StudioInfinity/dyna3 2024-11-18 19:50:06 +00:00
b479e57446 Start assembly serial number at zero
Vectornaut commented on pull request StudioInfinity/dyna3#21 2024-11-18 19:45:50 +00:00
Fix element list updates

Whoops, I just remembered why I didn't store the serial number in the assembly. Right now, for simplicity, the application state just contains one fixed Assembly object. There's no code for…