As discussed in our meeting, I've gone back to the atomic version, with one change: we now panic when we run out of serial numbers, rather than silently wrapping around. Ready to review again!
As discussed over e-mail, we'll go with the thread-local version for now. Ready to review!
As far as I know, dyna3
should be single-threaded right now, so for parsimony we could instead store the next serial number in a thread-local cell, as suggested in [this other StackOverflow…
As we discussed in our meeting today, this PR has been superseded by #22. I'm keeping the outline-update-fix
branch in case we decide later that we'd rather use this alternate approach.
Whoops, I just remembered why I didn't store the serial number in the assembly. Right now, for simplicity, the application state just contains one fixed Assembly
object. There's no code for…
If you'd prefer, you could just have each Assembly grab a serial number from the state when it is created
That would simplify the code a little, and it might have a slight advantage over…
We've decided to leave the element list update bug (#20) in this PR, and fix it in a subsequent PR.