Done (commits ee8a01b – 52d9975). To me, the code that creates and inserts regulators looks much better-organized now!
Done, by making CURVATURE_COMPONENT an associated constant of the Element structure (commit 7f21e7e). When we introduce separate structures for different kinds of elements, this one will go in…
I also just realized that the names of the two regulators are not parallel: currently they are "HalfCurvatureRegulator" and "ProductRegulator". The first is geometry-centric, the second is…
But such code should be part of the code for that flavor of regulator, not in an "outside" method like this insertion gadget.
I think that's a great idea. I propose moving the insertion code…
I've made the changes we discussed during our last meeting, so this should be ready for review again!
On the other hand, the engine does provide representation-specific implementations of other user-facing, mostly-representation-agnostic tasks […]. If we can find a mostly-representation-agnosti…
Good to know. For now, I think it's worth clearly distinguishing the interior "builder" variable and the exterior "storage" variable, because they have some differences in usage: for example, the…
C) This very much has the look of engine code that has leaked into the assembly: nitty gritty dealing with the internal coordinates of an element.
Yes, I think this code is on the border…
B) Why do you have to do so much work updating the guess (I think that's what's going on) when you start regulating curvature, but it seems like you don't do much of anything when you start…
A) Seems like there is some duplication at least of structure/behavior here with the insert_new_product_regulator; is there anything that can be profitable factored out (some common insert_regula…
It also seems to me that Elements are ProblemPosers as well, but it's fine if that's not reflected in the software structure in this PR -- but you may want to contemplate that for #27.
Yes,…
I've fixed the example switcher regression and removed the work-in-progress flag! (The example switcher is now equally buggy on the main branch and on the branch to be merged. I'm not sure whether…
I've marked this PR as a work in progress because the example switcher is broken as of commit 81e423f. You're welcome to start reviewing while I debug the example switcher, because I expect the…