No, I have now updated the "branch protection" settings for the repository so that if /test is failing, merge is not allowed.
Awesome. I've confirmed that I'm blocked from merging too.
Oops, I can still merge this PR even in a failing state. I will try to adjust the settings.
While you look at the repository settings (or review efb2d39 and 440b1df), I'll check whether this…
It's not too big a deal either way since I can't imagine either of us merging a failing PR. but do feel free to commit and revert a bad commit to check if you like. Just let me know whether you…
What I meant was: it was our intention that trunk be installed in a directory ci-bin created at the top level of the project hierarchy.
Got it! It turns out that the setup-trunk action…
The GitHub Actions documentation is clearer about [how the path to a local action is specified](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using…
In the setup-trunk action, you added the comment: "Assume we remain in the top-level directory of the checkout." It seems to me, though, that it doesn't really matter where setup-trunk runs;…
Thanks for taking care of the Trunk install path change! In the process, did you notice whether merging was disabled on the commits where CI failed? (If not, I'll check with a deliberately failing…
Oh, now I remember how to do this! You have to write to the GITHUB_PATH variable. I did this in the [setup-rust](https://code.studioinfinity.org/Vectornaut/dyna3/src/commit/bbfdf2b87f562772aa02…
People in the Rust ecosystem consistently seem to say that CARGO_HOME is meant to be set before setting up the Rust toolchain [1][[2](https://github.com/ru…
The ideal is that as long as a "cargo" command of sufficiently high version is findable/executable when invoked simply as "cargo", then nothing else from the context/environment is needed/used,…
In fact, there seems to be a CARGO_HOME environment variable. I'd rather set that to someplace in our directory tree to keep this self-contained.
Could you clarify what you mean by "self-conta…
Good point: it would be nice to make the setup-trunk action more container-independent. I think I've done this in commit df2d458. There may be a cleaner way to do it, but this is the best I…
By the way, it turns out that Sycamore doesn't currently enforce a minimum Rust version at compile time, but the maintainer has [okayed](https://github.com/sycamore-rs/sycamore/issues/191#issuecomm…