StudioInfinity/dyna3
2
0
Fork 1
Code Issues 44 Pull requests Projects 2 Releases 2 Wiki Activity Actions

Generalize constraints to observables #48

Merged
glen merged 25 commits from Vectornaut/dyna3:observables_on_main into main 2025-03-10 23:43:25 +00:00
Conversation 69 Commits 25 Files changed 7 +1 -8
2 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c58fed073d - Show all commits

2
app-proto/src/assembly.rs
View file

@ -269,7 +269,7 @@ impl Assembly {
console::log_1(&JsValue::from(
format!("Updated constraint with subjects ({}, {})", subjects.0, subjects.1)
));
if set_point.with(|set_pt| set_pt.is_present()) {
if set_point.with(|set_pt| matches!(set_pt, Present { .. })) {
self.realize();
}
});
glen marked this conversation as resolved Outdated
glen commented 2025-02-26 00:18:36 +00:00
Outdated
Review
Copy link

Should this really be pub? Where would a client of Assembly get a "free-floating" regulator to insert? Seems, at least for the moment, like a private helper for insert_new_regulator, and indeed, at the moment it is only called from there.

Should this really be `pub`? Where would a client of Assembly get a "free-floating" regulator to insert? Seems, at least for the moment, like a private helper for `insert_new_regulator`, and indeed, at the moment it is only called from there.
Vectornaut commented 2025-02-27 08:30:56 +00:00
Outdated
Review
Copy link

Good point! I've made insert_regulator private for now (c368a38).

Good point! I've made `insert_regulator` private for now (c368a38).

7
app-proto/src/specified.rs
View file

@ -26,13 +26,6 @@ impl SpecifiedValue {
Present { spec, .. } => spec.clone()
}
}
pub fn is_present(&self) -> bool {
match self {
Absent => false,
Present { .. } => true
}
}
}
// we can try to turn a specification string into a `SpecifiedValue`. if the