StudioInfinity/dyna3
2
0
Fork 1
Code Issues 44 Pull requests Projects 2 Releases 2 Wiki Activity Actions

Generalize constraints to observables #48

Merged
glen merged 25 commits from Vectornaut/dyna3:observables_on_main into main 2025-03-10 23:43:25 +00:00
Conversation 69 Commits 25 Files changed 7 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c368a38803 - Show all commits

2
app-proto/src/assembly.rs
View file

@ -272,7 +272,7 @@ impl Assembly {
);
}
pub fn insert_regulator(&self, regulator: Regulator) {
fn insert_regulator(&self, regulator: Regulator) {
glen marked this conversation as resolved Outdated
glen commented 2025-02-26 00:18:36 +00:00
Outdated
Review
Copy link

Should this really be pub? Where would a client of Assembly get a "free-floating" regulator to insert? Seems, at least for the moment, like a private helper for insert_new_regulator, and indeed, at the moment it is only called from there.

Should this really be `pub`? Where would a client of Assembly get a "free-floating" regulator to insert? Seems, at least for the moment, like a private helper for `insert_new_regulator`, and indeed, at the moment it is only called from there.
Vectornaut commented 2025-02-27 08:30:56 +00:00
Outdated
Review
Copy link

Good point! I've made insert_regulator private for now (c368a38).

Good point! I've made `insert_regulator` private for now (c368a38).
let subjects = regulator.subjects;
let key = self.regulators.update(|regs| regs.insert(regulator));
let subject_regulators = self.elements.with(
glen marked this conversation as resolved Outdated
glen commented 2025-02-26 00:22:58 +00:00
Outdated
Review
Copy link

Isn't there a way in Rust to just do the equivalent of JavaScript's forEach on the two entries of subjects, looking the entry up in elts and updating the regulators of each by inserting key in them? I mean, rather than non-DRY-ly having to write two identical update calls?

Isn't there a way in Rust to just do the equivalent of JavaScript's `forEach` on the two entries of subjects, looking the entry up in elts and updating the regulators of each by inserting key in them? I mean, rather than non-DRY-ly having to write two identical update calls?
Vectornaut commented 2025-02-26 20:56:09 +00:00
Outdated
Review
Copy link

I think tuples are designed with arbitrary combinations of types in mind, so I'd be surprised to find utility methods to broadcast over tuples of the same type—and indeed, I haven't managed to find any.

If we change the subjects field from a tuple to a fixed-length array, as I'm expecting to do when we address issue #55, we can make this code less repetitive by iterating over the array.

I think tuples are designed with arbitrary combinations of types in mind, so I'd be surprised to find utility methods to broadcast over tuples of the same type—and indeed, I haven't managed to find any. If we change the `subjects` field from a tuple to a fixed-length array, as I'm expecting to do when we address issue #55, we can make this code less repetitive by iterating over the array.
glen commented 2025-02-27 03:42:21 +00:00
Outdated
Review
Copy link

Ah, this strongly suggests that the subjects field should be a fixed-length array, if there is no way to iterate over the entries of a tuple. So let's make that a definite part of the plan for #55, and I'll resolve this here.

Ah, this strongly suggests that the subjects field should be a fixed-length array, if there is no way to iterate over the entries of a tuple. So let's make that a definite part of the plan for #55, and I'll resolve this here.