StudioInfinity/dyna3
2
0
Fork 1
Code Issues 44 Pull requests Projects 2 Releases 2 Wiki Activity Actions

Generalize constraints to observables #48

Merged
glen merged 25 commits from Vectornaut/dyna3:observables_on_main into main 2025-03-10 23:43:25 +00:00
Conversation 69 Commits 25 Files changed 7 +16 -11
2 changed files with 16 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit bbd0835a8f - Show all commits

13
app-proto/src/assembly.rs
View file

@ -120,6 +120,19 @@ pub struct Regulator {
pub set_point_spec: Signal<String>
glen marked this conversation as resolved Outdated
glen commented 2025-02-25 23:49:20 +00:00
Outdated
Review
Copy link

Tiny writing nit: this is a "garden path" phrasing -- I read "format discussed above" and started looking for the format specification earlier in the file, since I was pretty sure I hadn't seen one. Maybe reword just a bit to avoid that trap I fell into?

Tiny writing nit: this is a "garden path" phrasing -- I read "format discussed above" and started looking for the format specification earlier in the file, since I was pretty sure I hadn't seen one. Maybe reword just a bit to avoid that trap I fell into?
Vectornaut commented 2025-02-27 08:34:08 +00:00
Outdated
Review
Copy link

Nice catch! I've changed "above" to "at" to resolve the ambiguity (7cbd926). Does that read all right to you?

Nice catch! I've changed "above" to "at" to resolve the ambiguity (7cbd926). Does that read all right to you?
glen commented 2025-03-01 01:32:09 +00:00
Outdated
Review
Copy link

I agree unambiguous now. And hopefully this will change to an explicit anchor link when we get the doc system set up. So resolving.

I agree unambiguous now. And hopefully this will change to an explicit anchor link when we get the doc system set up. So resolving.
}
impl Regulator {
pub fn try_specify_set_point(&self, spec: String) -> bool {
match spec.parse::<f64>() {
Err(_) if !spec.is_empty() => false,
set_pt => {
self.set_point.set(set_pt.ok());
self.set_point_spec.set(spec);
true
}
}
}
}
// the velocity is expressed in uniform coordinates
pub struct ElementMotion<'a> {
pub key: ElementKey,

14
app-proto/src/outline.rs
View file

@ -50,17 +50,9 @@ fn RegulatorInput(regulator: Regulator) -> View {
},
placeholder=regulator.measurement.with(|result| result.to_string()),
bind:value=value,
on:change=move |_| {
let value_val = value.get_clone_untracked();
match value_val.parse::<f64>() {
Err(_) if !value_val.is_empty() => valid.set(false),
set_pt => batch(|| {
regulator.set_point.set(set_pt.ok());
regulator.set_point_spec.set(value_val);
valid.set(true);
})
};
},
on:change=move |_| valid.set(
regulator.try_specify_set_point(value.get_clone_untracked())
),
on:keydown={
move |event: KeyboardEvent| {
match event.key().as_str() {