Tidy up engine tests #64

New issue

Closed

opened 2025-02-27 21:14:28 +00:00 by Vectornaut · 1 comment

Vectornaut commented

2025-02-27 21:14:28 +00:00

Member

`zero_loss_test`

Drop the redundant type hint in the definition of a (done in #72).

`tangent_test`

Rename to tangent_test_three_spheres to make room for a kaleidocycle tangent test (done in #34).
Turn the ELEMENT_DIM and ASSEMBLY_DIM constants into parameters read off from the guess (done in #34).
Don't bother packing and unpacking the uniform motions into a matrix (done in #34).
Get the dimension from the expected basis, rather than putting it in by hand (done in #72).

`tangent_test_kaleidocycle`

Factor out the realization code, in the same style as realize_irisawa_hexlet (done in #72).
Rename the irisawa submodule to examples (done in #72).

`frozen_entry_test`

Move up into the section for simpler tests, between zero_loss_test and irisawa_hexlet_test (done in #72).

### `zero_loss_test` - [x] Drop the redundant type hint in the definition of `a` *(done in #72)*. ### `tangent_test` - [x] Rename to `tangent_test_three_spheres` to make room for a kaleidocycle tangent test *(done in #34)*. - [x] Turn the `ELEMENT_DIM` and `ASSEMBLY_DIM` constants into parameters read off from the guess *(done in #34)*. - [x] Don't bother packing and unpacking the uniform motions into a matrix *(done in #34)*. - [x] Get the dimension from the expected basis, rather than putting it in by hand *(done in #72)*. ### `tangent_test_kaleidocycle` - [x] Factor out the realization code, in the same style as `realize_irisawa_hexlet` *(done in #72)*. - [x] Rename the `irisawa` submodule to `examples` *(done in #72)*. ### `frozen_entry_test` - [x] Move up into the section for simpler tests, between `zero_loss_test` and `irisawa_hexlet_test` *(done in #72)*.