Correct the argument-count error messages for Sphere and Point descriptors #156

Closed
opened 2026-06-12 22:29:03 +00:00 by Vectornaut · 3 comments
Member

As of pull request #155, we return an interpretation error when a Sphere or Point descriptor is given arguments, instead of just ignoring the extra arguments. The error message shouldn't describe Sphere and Point as regulators.

As of pull request #155, we return an interpretation error when a `Sphere` or `Point` descriptor is given arguments, instead of just ignoring the extra arguments. The error message shouldn't describe `Sphere` and `Point` as regulators.
Owner

Why don't you just push a commit to #155 fixing this since it is not merged yet? Thanks.

Why don't you just push a commit to #155 fixing this since it is not merged yet? Thanks.
Author
Member

Just posted a comment on pull request #155 to explain this! I'm happy to address this in #155, but it will increase the chances of a regression in the next pull request a little bit.

Just posted a [comment](pulls/155#issuecomment-3976) on pull request #155 to explain this! I'm happy to address this in #155, but it will increase the chances of a regression in the next pull request a little bit.
Author
Member

As requested, I've updated pull request #155 to correct this problem, so it should never arise on the main branch. When I rebased the next pull request, I managed to get a clean enough diff to be confident it won't lead to a regression.

As [requested](pulls/155#issuecomment-3983), I've updated pull request #155 to correct this problem, so it should never arise on the main branch. When I rebased the next pull request, I managed to get a clean enough diff to be confident it won't lead to a regression.
Sign in to join this conversation.
No description provided.