Correct the argument-count error messages for Sphere and Point descriptors #156
Labels
No labels
bug
ci
design
duplicate
engine
enhancement
maintenance
prospective
question
regression
stub
todo
ui
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
StudioInfinity/dyna3#156
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As of pull request #155, we return an interpretation error when a
SphereorPointdescriptor is given arguments, instead of just ignoring the extra arguments. The error message shouldn't describeSphereandPointas regulators.Why don't you just push a commit to #155 fixing this since it is not merged yet? Thanks.
Just posted a comment on pull request #155 to explain this! I'm happy to address this in #155, but it will increase the chances of a regression in the next pull request a little bit.
As requested, I've updated pull request #155 to correct this problem, so it should never arise on the main branch. When I rebased the next pull request, I managed to get a clean enough diff to be confident it won't lead to a regression.