Improve creation/specification of SpecifiedValues and/or setting of Regulators #127

New issue

Open

opened 2025-10-11 02:21:49 +00:00 by glen · 0 comments

glen commented

2025-10-11 02:21:49 +00:00

Owner

In creating the 80-character PR, I have encountered many expressions like

    outer_curvature_regulator.set_point().set(
        SpecifiedValue::try_from((1.0 / 3.0).to_string()).unwrap()
    );

particularly in the test_asembly_chooser. We can't have gotten it right if setting a regulator to a known float is this hard. We should aspire for something like

    outer_curvature_regulator.set_to(1./3.)

or something like that.

In creating the 80-character PR, I have encountered many expressions like ``` outer_curvature_regulator.set_point().set( SpecifiedValue::try_from((1.0 / 3.0).to_string()).unwrap() ); ``` particularly in the test_asembly_chooser. We can't have gotten it right if setting a regulator to a known float is this hard. We should aspire for something like ``` outer_curvature_regulator.set_to(1./3.) ``` or something like that.

glen added the

maintenance

label 2025-10-11 02:21:49 +00:00

glen changed title from ~~Improve creation/specification of SpecifiedValues~~ to Improve creation/specification of SpecifiedValues and/or setting of Regulators

2025-10-11 02:22:09 +00:00