josdejong
0 followers · 0 following
  • Joined on 2022-10-05
Repositories Projects Packages Public activity Starred repositories
josdejong commented on pull request glen/math5#13 2024-10-31 09:47:17 +00:00
Enable testing with vitest

Ah, yes I've see the tests-in-sourcefile approach when I recently tried out Rust.

I'm ok with trying it out (especially inside a POC). I'm totally fine with the idea in general. I doubt…

josdejong commented on pull request glen/math5#13 2024-10-28 09:48:28 +00:00
Enable testing with vitest

I've pushed a commit to not run vitest in watch mode for now. I think later on we can look into running the build, reflect, and test scripts all in a watch mode. I don't think that is the highest…

josdejong pushed to test/vitest at glen/math5 2024-10-28 09:47:36 +00:00
11a0e22f96 fix: do not run vitest in watch mode (since we rely on a build step right now)
josdejong commented on pull request glen/math5#13 2024-10-28 09:30:48 +00:00
Enable testing with vitest

All runs fine on Windows, nice job :)

Two thoughts:

  1. I'm used to putting tests in a separate file with a name like .test.ts, and without the if (import.meta.vitest) conditionals, since…
josdejong commented on issue glen/math5#10 2024-10-25 07:20:23 +00:00
Implement basic dispatch.

(A) About the actual-call-signature idea: I think a drawback may be performance, but it really requires a benchmark to figure that out (creating strings is slow, but a lookup in a map is fast). It…

josdejong commented on issue glen/math5#10 2024-10-22 07:16:44 +00:00
Implement basic dispatch.

Yes! Are you going to give this a shot? As soon as there is a bare-bone implementation, I think I can start working on implementing more functions for it.

josdejong commented on issue glen/math5#1 2024-10-22 07:15:25 +00:00
math5 vs dispatch_refactor approach

Yes let's close this issue. I'm looking forward to the next step :)

josdejong closed issue glen/math5#1 2024-10-22 07:15:25 +00:00
math5 vs dispatch_refactor approach
josdejong commented on issue glen/math5#1 2024-10-21 18:23:21 +00:00
math5 vs dispatch_refactor approach

Ok the Windows issue will be solved 😁, I've pushed a commit in main: 2a8823c5f7

josdejong pushed to main at glen/math5 2024-10-21 18:22:37 +00:00
2a8823c5f7 fix: ts2json not working on Windows
josdejong commented on pull request glen/math5#8 2024-10-21 18:20:07 +00:00
chore: Remove string-based type injection via ship()

Fine with me, you can press the merge button 👍

josdejong commented on issue glen/math5#1 2024-10-21 09:35:55 +00:00
math5 vs dispatch_refactor approach

So, in short: let's keep the POC as it is right now, built a first version of the dispatcher, and after that see if there is need to finetune the API's.

(5) O: and about the naming of the…

josdejong commented on issue glen/math5#1 2024-10-21 09:29:41 +00:00
math5 vs dispatch_refactor approach

Ha ha, you managed to produce a "mega post" for point 2 alone 😉

  1. 👍
  2. (b) In the past, I have avoided using Symbol for such cases and used a "unique enough" property because Symbols…
josdejong pushed to feat/parse-reflection at glen/math5 2024-10-18 10:05:14 +00:00
201ef0ae7d chore: make pnpm go work on both windows and linux 😅
josdejong commented on issue glen/math5#1 2024-10-18 09:55:46 +00:00
math5 vs dispatch_refactor approach

This math5 approach looks more and more promising Glen! Awesome. The separate build step is working out quite nicely.

  1. I love the _reflectedType6 JSON structure! This should be easy to…
josdejong commented on issue glen/math5#1 2024-10-18 08:58:25 +00:00
math5 vs dispatch_refactor approach

O wow, works in Ubuntu via WSL. That is interesting.

josdejong commented on issue glen/math5#1 2024-10-18 08:53:04 +00:00
math5 vs dispatch_refactor approach

That sounds promising! I've checked out feat/parse-reflection but I see the logging like:

Defs from C:\Users\wjosd\projects\misc\math5\build\numbers\arithmetic.d.ts are undefined

…

josdejong commented on issue glen/math5#1 2024-10-15 07:55:28 +00:00
math5 vs dispatch_refactor approach

Yes I'm getting email notifications again!

Good idea to try use the TypeScript parser itself to parse the .d.ts files, that would be nice. That will save us quite some work, then we only have…

josdejong commented on issue glen/math5#1 2024-10-11 11:41:30 +00:00
math5 vs dispatch_refactor approach

@glen I've pushed a branch feat/reflect-types where I experimented with a script [./tools/reflectTypes.mjs](https://c…

josdejong pushed to feat/reflect-types at glen/math5 2024-10-11 11:37:13 +00:00
2780518d97 chore: inject the reflected type information inside the .ship() occurrences