From b94280c456402700252f0c51fb92598f41fa68b8 Mon Sep 17 00:00:00 2001
From: Aaron Fenyes <aaron.fenyes@fareycircles.ooo>
Date: Fri, 1 Nov 2024 20:40:25 -0700
Subject: [PATCH] Test representation validity in realization effect

---
 app-proto/src/add_remove.rs | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/app-proto/src/add_remove.rs b/app-proto/src/add_remove.rs
index 7ee20aa..bea20f9 100644
--- a/app-proto/src/add_remove.rs
+++ b/app-proto/src/add_remove.rs
@@ -187,15 +187,15 @@ pub fn AddRemove() -> View {
                         }
                     );
                     let lorentz_prod = create_signal(0.0);
+                    let lorentz_prod_valid = create_signal(false);
                     let active = create_signal(true);
                     state.assembly.insert_constraint(Constraint {
                         subjects: subjects,
                         lorentz_prod: lorentz_prod,
                         lorentz_prod_text: create_signal(String::new()),
-                        lorentz_prod_valid: create_signal(false),
+                        lorentz_prod_valid: lorentz_prod_valid,
                         active: active,
                     });
-                    state.assembly.realize();
                     state.selection.update(|sel| sel.clear());
                     
                     /* DEBUG */
@@ -213,15 +213,14 @@ pub fn AddRemove() -> View {
                         }
                     });
                     
-                    // update the realization when the constraint is activated,
-                    // or edited while active
+                    // update the realization when the constraint becomes active
+                    // and valid, or is edited while active and valid
                     create_effect(move || {
+                        console::log_1(&JsValue::from(
+                            format!("Constraint ({}, {}) updated", subjects.0, subjects.1)
+                        ));
                         lorentz_prod.track();
-                        console::log_2(
-                            &JsValue::from("Lorentz product updated to"),
-                            &JsValue::from(lorentz_prod.get_untracked())
-                        );
-                        if active.get() {
+                        if active.get() && lorentz_prod_valid.get() {
                             state.assembly.realize();
                         }
                     });