Compare commits

...

2 commits

Author SHA1 Message Date
Aaron Fenyes
2bae8d3df9 Prevent unused imports for engine debug output
In the process, switch from the `web-sys` crate's `console::log_1`
function to Sycamore's more flexible `console_log` macro. The latter
works both inside and outside the browser, so we can use it without
checking whether we're compiling to WebAssembly.
2025-07-24 16:32:18 -07:00
Aaron Fenyes
03d6cf0687 Flag our workaround for a Sycamore batching bug
Add a reminder to remove the workaround once the bug is fixed.
2025-07-24 16:09:26 -07:00
2 changed files with 16 additions and 5 deletions

View file

@ -18,6 +18,16 @@ pub fn AddRemove() -> View {
// this call is batched to avoid redundant realizations. // this call is batched to avoid redundant realizations.
// it updates the element list and the regulator list, // it updates the element list and the regulator list,
// which are both tracked by the realization effect // which are both tracked by the realization effect
/* TO DO */
// it would make more to do the batching inside
// `insert_element_default`, but that will have to wait
// until Sycamore handles nested batches correctly.
//
// https://github.com/sycamore-rs/sycamore/issues/802
//
// the nested batch issue is relevant here because the
// assembly loaders in the test assembly chooser use
// `insert_element_default` within larger batches
state.assembly.insert_element_default::<Sphere>(); state.assembly.insert_element_default::<Sphere>();
}); });
} }

View file

@ -1,7 +1,10 @@
use lazy_static::lazy_static; use lazy_static::lazy_static;
use nalgebra::{Const, DMatrix, DVector, DVectorView, Dyn, SymmetricEigen}; use nalgebra::{Const, DMatrix, DVector, DVectorView, Dyn, SymmetricEigen};
use std::fmt::{Display, Error, Formatter}; use std::fmt::{Display, Error, Formatter};
use web_sys::{console, wasm_bindgen::JsValue}; /* DEBUG */
/* DEBUG */
#[cfg(not(feature = "dev"))]
use sycamore::prelude::console_log;
// --- elements --- // --- elements ---
@ -167,10 +170,8 @@ impl ConfigSubspace {
/* DEBUG */ /* DEBUG */
// print the eigenvalues // print the eigenvalues
#[cfg(all(target_family = "wasm", target_os = "unknown"))] #[cfg(not(feature = "dev"))]
console::log_1(&JsValue::from( console_log!("Eigenvalues used to find kernel:{}", eig.eigenvalues);
format!("Eigenvalues used to find kernel:{}", eig.eigenvalues)
));
// express the basis in the standard coordinates // express the basis in the standard coordinates
let basis_std = proj_to_std * &basis_proj; let basis_std = proj_to_std * &basis_proj;