From 894931a6e77815b5f2aabd6ba8bb1055d4e9ba52 Mon Sep 17 00:00:00 2001
From: Aaron Fenyes <aaron.fenyes@fareycircles.ooo>
Date: Mon, 3 Mar 2025 11:43:43 -0800
Subject: [PATCH] Replace `try_set` with `set_if_ok`

---
 app-proto/src/assembly.rs | 12 +++++-------
 app-proto/src/outline.rs  |  9 ++++++---
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/app-proto/src/assembly.rs b/app-proto/src/assembly.rs
index d30a371..9b123f5 100644
--- a/app-proto/src/assembly.rs
+++ b/app-proto/src/assembly.rs
@@ -181,13 +181,11 @@ pub struct Regulator {
 }
 
 impl Regulator {
-    pub fn try_set(&self, set_pt_spec: String) -> bool {
-        match SpecifiedValue::try_from(set_pt_spec) {
-            Ok(set_pt) => {
-                self.set_point.set(set_pt);
-                true
-            }
-            Err(_) => false
+    /* TO DO */
+    // if it's called for, add a `set` method that takes a bare SpecifiedValue
+    pub fn set_if_ok<E>(&self, set_pt_result: Result<SpecifiedValue, E>) {
+        if let Ok(set_pt) = set_pt_result {
+            self.set_point.set(set_pt);
         }
     }
 }
diff --git a/app-proto/src/outline.rs b/app-proto/src/outline.rs
index 04bda9a..8f81a82 100644
--- a/app-proto/src/outline.rs
+++ b/app-proto/src/outline.rs
@@ -13,6 +13,7 @@ use crate::{
         ElementKey,
         Regulator,
         RegulatorKey,
+        SpecifiedValue,
         SpecifiedValue::*
     }
 };
@@ -55,9 +56,11 @@ fn RegulatorInput(regulator: Regulator) -> View {
             },
             placeholder=regulator.measurement.with(|result| result.to_string()),
             bind:value=value,
-            on:change=move |_| valid.set(
-                regulator.try_set(value.get_clone_untracked())
-            ),
+            on:change=move |_| {
+                let set_pt_result = SpecifiedValue::try_from(value.get_clone_untracked());
+                valid.set(set_pt_result.is_ok());
+                regulator.set_if_ok(set_pt_result);
+            },
             on:keydown={
                 move |event: KeyboardEvent| {
                     match event.key().as_str() {