From 6eeeb1c6fddc2c4122ec2eaf9146a0c839bf7def Mon Sep 17 00:00:00 2001
From: Aaron Fenyes <aaron.fenyes@fareycircles.ooo>
Date: Wed, 5 Mar 2025 15:05:00 -0800
Subject: [PATCH] Bring back `try_set` as inline code

This essentially reverts commit 894931a and then inlines `try_set` in
the one place where it's used. If we ever want to reuse that code, we'll
factor it out again.
---
 app-proto/src/assembly.rs | 10 ----------
 app-proto/src/outline.rs  | 12 +++++++++---
 2 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/app-proto/src/assembly.rs b/app-proto/src/assembly.rs
index 0881741..18176df 100644
--- a/app-proto/src/assembly.rs
+++ b/app-proto/src/assembly.rs
@@ -124,16 +124,6 @@ pub struct Regulator {
     pub set_point: Signal<SpecifiedValue>
 }
 
-impl Regulator {
-    /* TO DO */
-    // if it's called for, add a `set` method that takes a bare SpecifiedValue
-    pub fn set_if_ok<E>(&self, set_pt_result: Result<SpecifiedValue, E>) {
-        if let Ok(set_pt) = set_pt_result {
-            self.set_point.set(set_pt);
-        }
-    }
-}
-
 // the velocity is expressed in uniform coordinates
 pub struct ElementMotion<'a> {
     pub key: ElementKey,
diff --git a/app-proto/src/outline.rs b/app-proto/src/outline.rs
index bc920f3..8e40140 100644
--- a/app-proto/src/outline.rs
+++ b/app-proto/src/outline.rs
@@ -57,9 +57,15 @@ fn RegulatorInput(regulator: Regulator) -> View {
             placeholder=regulator.measurement.with(|result| result.to_string()),
             bind:value=value,
             on:change=move |_| {
-                let set_pt_result = SpecifiedValue::try_from(value.get_clone_untracked());
-                valid.set(set_pt_result.is_ok());
-                regulator.set_if_ok(set_pt_result);
+                valid.set(
+                    match SpecifiedValue::try_from(value.get_clone_untracked()) {
+                        Ok(set_pt) => {
+                            regulator.set_point.set(set_pt);
+                            true
+                        }
+                        Err(_) => false
+                    }
+                )
             },
             on:keydown={
                 move |event: KeyboardEvent| {